staging: greybus: Remove redundant variable 'mask'
authorColin Ian King <colin.i.king@gmail.com>
Thu, 29 Feb 2024 12:05:41 +0000 (12:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Mar 2024 13:59:28 +0000 (13:59 +0000)
The variable mask is being assigned and bit-set but it is never
being used apart from this. The variable is redundant and can
be removed.

Cleans up clang scan build warning:
drivers/staging/greybus/audio_topology.c:764:15: warning: variable 'mask'
set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Link: https://lore.kernel.org/r/20240229120541.219429-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/greybus/audio_topology.c

index 08e6a807c1327dd1c500bc5b9f2e026f0160bf2c..5dc4721105d445ba120a758345e07d2e3c58f42f 100644 (file)
@@ -761,7 +761,6 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kcontrol *kcontrol,
 {
        int ret, wi, ctl_id;
        unsigned int val, mux, change;
-       unsigned int mask;
        struct snd_soc_dapm_widget_list *wlist = snd_kcontrol_chip(kcontrol);
        struct snd_soc_dapm_widget *widget = wlist->widgets[0];
        struct gb_audio_ctl_elem_value gbvalue;
@@ -802,7 +801,6 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kcontrol *kcontrol,
 
        mux = ucontrol->value.enumerated.item[0];
        val = mux << e->shift_l;
-       mask = e->mask << e->shift_l;
 
        if (le32_to_cpu(gbvalue.value.enumerated_item[0]) !=
            ucontrol->value.enumerated.item[0]) {
@@ -815,7 +813,6 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kcontrol *kcontrol,
                if (ucontrol->value.enumerated.item[1] > e->items - 1)
                        return -EINVAL;
                val |= ucontrol->value.enumerated.item[1] << e->shift_r;
-               mask |= e->mask << e->shift_r;
                if (le32_to_cpu(gbvalue.value.enumerated_item[1]) !=
                    ucontrol->value.enumerated.item[1]) {
                        change = 1;