projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
25a3b95
)
ALSA: hda: cs35l41: Clarify support for CSC3551 without _DSD Properties
author
Stefan Binding
<sbinding@opensource.cirrus.com>
Mon, 15 Aug 2022 16:29:06 +0000
(17:29 +0100)
committer
Takashi Iwai
<tiwai@suse.de>
Tue, 16 Aug 2022 13:11:49 +0000
(15:11 +0200)
For devices which use HID CSC3551, correct ACPI _DSD properties are
required to be able support those systems.
Add error message to clarify this.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Link:
https://lore.kernel.org/r/20220815162906.463108-1-sbinding@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/cs35l41_hda.c
patch
|
blob
|
history
diff --git
a/sound/pci/hda/cs35l41_hda.c
b/sound/pci/hda/cs35l41_hda.c
index 129bffb431c22e7f38c4e90dc7385a2899458870..15e2a0009080ee1ea1a22d518b7f95a729c645bf 100644
(file)
--- a/
sound/pci/hda/cs35l41_hda.c
+++ b/
sound/pci/hda/cs35l41_hda.c
@@
-1163,6
+1163,11
@@
static int cs35l41_no_acpi_dsd(struct cs35l41_hda *cs35l41, struct device *physd
hw_cfg->gpio1.func = CS35l41_VSPK_SWITCH;
hw_cfg->gpio1.valid = true;
} else {
+ /*
+ * Note: CLSA010(0/1) are special cases which use a slightly different design.
+ * All other HIDs e.g. CSC3551 require valid ACPI _DSD properties to be supported.
+ */
+ dev_err(cs35l41->dev, "Error: ACPI _DSD Properties are missing for HID %s.\n", hid);
hw_cfg->valid = false;
hw_cfg->gpio1.valid = false;
hw_cfg->gpio2.valid = false;