projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1b598f4
)
media: ov7251: fix mutex lock unbalance
author
Mauro Carvalho Chehab
<mchehab@kernel.org>
Fri, 13 May 2022 16:06:40 +0000
(18:06 +0200)
committer
Mauro Carvalho Chehab
<mchehab@kernel.org>
Tue, 17 May 2022 07:54:26 +0000
(09:54 +0200)
As reported by smatch/sparse:
drivers/media/i2c/ov7251.c:1381 ov7251_s_stream() warn: inconsistent returns '&ov7251->lock'.
Locked on : 1381
Unlocked on: 1377
There's a lock unbalance at this routine, as it keeps the lock on
certain errors. Fix it.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov7251.c
patch
|
blob
|
history
diff --git
a/drivers/media/i2c/ov7251.c
b/drivers/media/i2c/ov7251.c
index 4867dc86cd2e4eb4a99c811d0b69c90d700a7bb7..0e7be15bc20a7ea8c2ec59e4b96a19654c7f3a67 100644
(file)
--- a/
drivers/media/i2c/ov7251.c
+++ b/
drivers/media/i2c/ov7251.c
@@
-1378,6
+1378,7
@@
unlock_out:
err_power_down:
pm_runtime_put_noidle(ov7251->dev);
+ mutex_unlock(&ov7251->lock);
return ret;
}