iio: adc: ad_sigma_delta: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Apr 2024 11:33:04 +0000 (13:33 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Apr 2024 20:06:17 +0000 (21:06 +0100)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20240429113313.68359-2-wsa+renesas@sang-engineering.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad_sigma_delta.c

index 97a05f325df7cfac67a4bc060c158c4cdfd1fdb8..a2b87f6b7a071d8826598ed2b077efadbc25d05a 100644 (file)
@@ -206,7 +206,7 @@ int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
        unsigned int mode, unsigned int channel)
 {
        int ret;
-       unsigned long timeout;
+       unsigned long time_left;
 
        ret = ad_sigma_delta_set_channel(sigma_delta, channel);
        if (ret)
@@ -223,8 +223,8 @@ int ad_sd_calibrate(struct ad_sigma_delta *sigma_delta,
 
        sigma_delta->irq_dis = false;
        enable_irq(sigma_delta->irq_line);
-       timeout = wait_for_completion_timeout(&sigma_delta->completion, 2 * HZ);
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&sigma_delta->completion, 2 * HZ);
+       if (time_left == 0) {
                sigma_delta->irq_dis = true;
                disable_irq_nosync(sigma_delta->irq_line);
                ret = -EIO;