iommu: Fix error unwind in iommu_group_alloc()

If either iommu_group_grate_file() fails then the
iommu_group is leaked.

Destroy it on these error paths.

Found by kselftest/iommu/iommufd_fail_nth

Fixes: bc7d12b91bd3 ("iommu: Implement reserved_regions iommu-group sysfs file")
Fixes: c52c72d3dee8 ("iommu: Add sysfs attribyte for domain type")
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/0-v1-8f616bee028d+8b-iommu_group_alloc_leak_jgg@nvidia.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 42591766266d7941184d149220ee9026ac4da048..989c0c963be359ba26564d85060cb8690812527b 100644 (file)
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -798,12 +798,16 @@ struct iommu_group *iommu_group_alloc(void)
 
        ret = iommu_group_create_file(group,
                                      &iommu_group_attr_reserved_regions);
-       if (ret)
+       if (ret) {
+               kobject_put(group->devices_kobj);
                return ERR_PTR(ret);
+       }
 
        ret = iommu_group_create_file(group, &iommu_group_attr_type);
-       if (ret)
+       if (ret) {
+               kobject_put(group->devices_kobj);
                return ERR_PTR(ret);
+       }
 
        pr_debug("Allocated group %d\n", group->id);