wifi: rtw89: wow: move release offload packet earlier for WoWLAN mode
authorChin-Yen Lee <timlee@realtek.com>
Sat, 2 Mar 2024 00:58:28 +0000 (08:58 +0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 5 Mar 2024 18:56:43 +0000 (20:56 +0200)
Now WoWLAN firmware will disable PCIE DMA after driver call cfg_wake
function, and it will lead to release offload packet fail because driver
can't receive completion notification from firmware. We move release
offload packet earlier to avoid this error.

Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240302005828.13666-8-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/wow.c

index 689a4e94387ab08e7def123c34f8c4008f25f12b..ccad026defb5048d42f448bf573e9b7eaaf2e02b 100644 (file)
@@ -667,14 +667,14 @@ static int rtw89_wow_fw_stop(struct rtw89_dev *rtwdev)
                goto out;
        }
 
+       rtw89_fw_release_general_pkt_list(rtwdev, true);
+
        ret = rtw89_wow_cfg_wake(rtwdev, false);
        if (ret) {
                rtw89_err(rtwdev, "wow: failed to disable config wake\n");
                goto out;
        }
 
-       rtw89_fw_release_general_pkt_list(rtwdev, true);
-
        ret = rtw89_wow_check_fw_status(rtwdev, false);
        if (ret) {
                rtw89_err(rtwdev, "wow: failed to check disable fw ready\n");