scsi: message: fusion: Use BUG_ON instead of if condition followed by BUG
authorzhouchuangao <zhouchuangao@vivo.com>
Tue, 30 Mar 2021 12:46:01 +0000 (05:46 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 6 Apr 2021 03:34:36 +0000 (23:34 -0400)
BUG_ON() uses unlikely in if() which can be optimized at compile time.

Link: https://lore.kernel.org/r/1617108361-6870-1-git-send-email-zhouchuangao@vivo.com
Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptsas.c

index 85aa5788826bca8d06af65593c8e0bf8e07b5163..1857869e7e8d572bd890ff597c946b7f5d575578 100644 (file)
@@ -3442,14 +3442,12 @@ mptsas_expander_event_add(MPT_ADAPTER *ioc,
        __le64 sas_address;
 
        port_info = kzalloc(sizeof(struct mptsas_portinfo), GFP_KERNEL);
-       if (!port_info)
-               BUG();
+       BUG_ON(!port_info);
        port_info->num_phys = (expander_data->NumPhys) ?
            expander_data->NumPhys : 1;
        port_info->phy_info = kcalloc(port_info->num_phys,
            sizeof(struct mptsas_phyinfo), GFP_KERNEL);
-       if (!port_info->phy_info)
-               BUG();
+       BUG_ON(!port_info->phy_info);
        memcpy(&sas_address, &expander_data->SASAddress, sizeof(__le64));
        for (i = 0; i < port_info->num_phys; i++) {
                port_info->phy_info[i].portinfo = port_info;