ALSA: scarlett2: Remove repeated elem->head.mixer references
authorGeoffrey D. Bennett <g@b4.vu>
Tue, 26 Dec 2023 18:06:13 +0000 (04:36 +1030)
committerTakashi Iwai <tiwai@suse.de>
Fri, 29 Dec 2023 14:52:12 +0000 (15:52 +0100)
Use a local variable *mixer rather than repeating elem->header.mixer
in scarlett2_direct_monitor_ctl_get() and scarlett2_meter_ctl_get().

Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/b21bacf4056366e10e01077e224d2b4970fdfe31.1703612638.git.g@b4.vu
sound/usb/mixer_scarlett2.c

index 6dd758cfb5cb74d84d752930883315290c5b87c6..8f466ad82d5a25ea70853aa589bbbd28c4d6f603 100644 (file)
@@ -3927,7 +3927,7 @@ static int scarlett2_direct_monitor_ctl_get(
 {
        struct usb_mixer_elem_info *elem = kctl->private_data;
        struct usb_mixer_interface *mixer = elem->head.mixer;
-       struct scarlett2_data *private = elem->head.mixer->private_data;
+       struct scarlett2_data *private = mixer->private_data;
        int err = 0;
 
        mutex_lock(&private->data_mutex);
@@ -4191,7 +4191,8 @@ static int scarlett2_meter_ctl_get(struct snd_kcontrol *kctl,
                                   struct snd_ctl_elem_value *ucontrol)
 {
        struct usb_mixer_elem_info *elem = kctl->private_data;
-       struct scarlett2_data *private = elem->head.mixer->private_data;
+       struct usb_mixer_interface *mixer = elem->head.mixer;
+       struct scarlett2_data *private = mixer->private_data;
        u8 *meter_level_map = private->meter_level_map;
        u16 meter_levels[SCARLETT2_MAX_METERS];
        int i, err;
@@ -4203,7 +4204,7 @@ static int scarlett2_meter_ctl_get(struct snd_kcontrol *kctl,
                goto unlock;
        }
 
-       err = scarlett2_usb_get_meter_levels(elem->head.mixer, elem->channels,
+       err = scarlett2_usb_get_meter_levels(mixer, elem->channels,
                                             meter_levels);
        if (err < 0)
                goto unlock;