media: adv748x: Only set i2c addresses once during probe
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Sun, 22 Nov 2020 16:30:48 +0000 (17:30 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 3 Dec 2020 06:46:55 +0000 (07:46 +0100)
During probe the i2c slave addresses are set two times in a row, once in
adv748x_initialise_clients() and once directly after in adv748x_reset().
Remove the call to adv748x_set_slave_addresses() in
adv748x_initialise_clients() as it's only called during probe while
adv748x_reset() is called during probe and normal operation.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/adv748x/adv748x-core.c

index ae8b7ebf3830aa1c9d406d4fd44d5c07e184d846..00966fe104881a14ac6a819c34e5e7eff8a321c2 100644 (file)
@@ -198,7 +198,7 @@ static int adv748x_initialise_clients(struct adv748x_state *state)
                        return ret;
        }
 
-       return adv748x_set_slave_addresses(state);
+       return 0;
 }
 
 /**