pcd: add error handling support for add_disk()
authorLuis Chamberlain <mcgrof@kernel.org>
Mon, 27 Sep 2021 22:01:07 +0000 (15:01 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 18 Oct 2021 20:41:36 +0000 (14:41 -0600)
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/paride/pcd.c

index 93ed636262328c02eb6dcde17d789c7ac341a732..a7fab3830d7b501afc1dc72b4f8b1da96fe93fea 100644 (file)
@@ -941,9 +941,13 @@ static int pcd_init_unit(struct pcd_unit *cd, bool autoprobe, int port,
        cd->present = 1;
        pcd_probe_capabilities(cd);
        register_cdrom(cd->disk, &cd->info);
-       add_disk(cd->disk);
+       ret = add_disk(cd->disk);
+       if (ret)
+               goto out_unreg_cdrom;
        return 0;
 
+out_unreg_cdrom:
+       unregister_cdrom(&cd->info);
 out_pi_release:
        pi_release(cd->pi);
 out_free_disk: