serial: core: sanitize RS485 delays read from device tree
authorLino Sanfilippo <l.sanfilippo@kunbus.com>
Sun, 10 Jul 2022 16:44:39 +0000 (18:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jul 2022 14:34:24 +0000 (16:34 +0200)
Currently the RTS delays set via device tree are not clamped to a maximum
value although the device tree bindings documentation for RS485 claims that
only a maximum of 1000 msecs is allowed.

So clamp the values to avoid arbitrary high delay settings. However clamp
the values to 100 instead of 1000 msecs to be consistent which the maximum
that is allowed when setting the delays from userspace via the UART ioctl
TIOCSRS485.

Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Link: https://lore.kernel.org/r/20220710164442.2958979-6-LinoSanfilippo@gmx.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/serial_core.c

index 3158f05a328cea364470fa18451ea39c8a324cfe..ac198d0d4c807a86b4a33b9fcd12d00d62e71a3f 100644 (file)
@@ -3395,6 +3395,8 @@ int uart_get_rs485_mode(struct uart_port *port)
                rs485conf->delay_rts_after_send = 0;
        }
 
+       uart_sanitize_serial_rs485_delays(port, rs485conf);
+
        /*
         * Clear full-duplex and enabled flags, set RTS polarity to active high
         * to get to a defined state with the following properties: