drm/amd/pm/powerplay/smumgr: use bitwise or for addition
authorDeepak R Varma <drv@mailo.com>
Sun, 15 Jan 2023 07:16:43 +0000 (12:46 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Jan 2023 21:11:51 +0000 (16:11 -0500)
For bit mask addition, it is recommended to use or operator "|" instead
of numerical addition as the former is quicker and cleaner. Change
suggested by orplus.cocci Coccinelle semantic patch.

Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Deepak R Varma <drv@mailo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c
drivers/gpu/drm/amd/pm/powerplay/smumgr/tonga_smumgr.c

index 03df35dee8ba8d01ffa2468dcc4e856d732c3620..060fc140c5744c94d420906c12736d1eaf7ffbca 100644 (file)
@@ -2165,7 +2165,7 @@ static int iceland_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)
        struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
 
        if (data->need_update_smu7_dpm_table &
-               (DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_OD_UPDATE_MCLK))
+               (DPMTABLE_OD_UPDATE_SCLK | DPMTABLE_OD_UPDATE_MCLK))
                return iceland_program_memory_timing_parameters(hwmgr);
 
        return 0;
index 04b561f5d932bc2620a7436befc6c759ef9bdf31..acbe41174d7e61522af8ee8356897aa221ae3aae 100644 (file)
@@ -2554,7 +2554,7 @@ static int tonga_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)
        struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);
 
        if (data->need_update_smu7_dpm_table &
-               (DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_OD_UPDATE_MCLK))
+               (DPMTABLE_OD_UPDATE_SCLK | DPMTABLE_OD_UPDATE_MCLK))
                return tonga_program_memory_timing_parameters(hwmgr);
 
        return 0;