phy: mvebu-cp110-comphy: Update comment about powering off all lanes at boot
authorMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 31 Jul 2019 12:21:19 +0000 (14:21 +0200)
committerKishon Vijay Abraham I <kishon@ti.com>
Tue, 27 Aug 2019 06:07:09 +0000 (11:37 +0530)
Now that all COMPHY modes are supported by the driver, update the
comment stating that mvebu_comphy_power_off() should be called for
each lane. This is still wrong because for compatibility reasons, it
might break users running an old firmware (the driver only uses SMC
calls for SATA, USB and PCIe configuration, there is no code in Linux
to fallback on in these cases.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/marvell/phy-mvebu-cp110-comphy.c

index 43cd99a693727519358ca02f9fd14b7226eb1175..847723a5c8f85c672fdf78b13c451a0a4feab454 100644 (file)
@@ -946,9 +946,11 @@ static int mvebu_comphy_probe(struct platform_device *pdev)
                phy_set_drvdata(phy, lane);
 
                /*
-                * Once all modes are supported in this driver we should call
+                * All modes are supported in this driver so we could call
                 * mvebu_comphy_power_off(phy) here to avoid relying on the
-                * bootloader/firmware configuration.
+                * bootloader/firmware configuration, but for compatibility
+                * reasons we cannot de-configure the COMPHY without being sure
+                * that the firmware is up-to-date and fully-featured.
                 */
        }