mlx4: Mark PM functions as __maybe_unused
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 2 Jul 2020 09:19:46 +0000 (17:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Jul 2020 21:24:17 +0000 (14:24 -0700)
In certain configurations without power management support, the
following warnings happen:

drivers/net/ethernet/mellanox/mlx4/main.c:4388:12:
 warning: 'mlx4_resume' defined but not used [-Wunused-function]
 4388 | static int mlx4_resume(struct device *dev_d)
      |            ^~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx4/main.c:4373:12: warning:
 'mlx4_suspend' defined but not used [-Wunused-function]
 4373 | static int mlx4_suspend(struct device *dev_d)
      |            ^~~~~~~~~~~~

Mark these functions as __maybe_unused to make it clear to the
compiler that this is going to happen based on the configuration,
which is the standard for these types of functions.

Fixes: 0e3e206a3e12 ("mlx4: use generic power management")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/main.c

index 4cae7db8d49c56e2a9918e2faabd2867d341577a..954c22c79f6b50cbc143414f9026e7ffb4aa706e 100644 (file)
@@ -4370,7 +4370,7 @@ static const struct pci_error_handlers mlx4_err_handler = {
        .resume         = mlx4_pci_resume,
 };
 
-static int mlx4_suspend(struct device *dev_d)
+static int __maybe_unused mlx4_suspend(struct device *dev_d)
 {
        struct pci_dev *pdev = to_pci_dev(dev_d);
        struct mlx4_dev_persistent *persist = pci_get_drvdata(pdev);
@@ -4385,7 +4385,7 @@ static int mlx4_suspend(struct device *dev_d)
        return 0;
 }
 
-static int mlx4_resume(struct device *dev_d)
+static int __maybe_unused mlx4_resume(struct device *dev_d)
 {
        struct pci_dev *pdev = to_pci_dev(dev_d);
        struct mlx4_dev_persistent *persist = pci_get_drvdata(pdev);