RDMA/qed: Use helper function to set GUIDs
authorKamal Heib <kamalheib1@gmail.com>
Sun, 31 Oct 2021 17:07:43 +0000 (19:07 +0200)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 1 Nov 2021 12:17:10 +0000 (09:17 -0300)
Use addrconf_addr_eui48() helper function to set the GUIDs and remove the
driver specific version.

Link: https://lore.kernel.org/r/20211031170743.81755-1-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/net/ethernet/qlogic/qed/qed_rdma.c

index 4f4b79250a2b2fdc8a9b4f33605c3b5238789416..4af24dc2e82ef3ba101d6a023bbb08b4ab1b3788 100644 (file)
@@ -19,6 +19,7 @@
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 #include <linux/string.h>
+#include <net/addrconf.h>
 #include "qed.h"
 #include "qed_cxt.h"
 #include "qed_hsi.h"
@@ -410,18 +411,6 @@ static void qed_rdma_free(struct qed_hwfn *p_hwfn)
        qed_rdma_resc_free(p_hwfn);
 }
 
-static void qed_rdma_get_guid(struct qed_hwfn *p_hwfn, u8 *guid)
-{
-       guid[0] = p_hwfn->hw_info.hw_mac_addr[0] ^ 2;
-       guid[1] = p_hwfn->hw_info.hw_mac_addr[1];
-       guid[2] = p_hwfn->hw_info.hw_mac_addr[2];
-       guid[3] = 0xff;
-       guid[4] = 0xfe;
-       guid[5] = p_hwfn->hw_info.hw_mac_addr[3];
-       guid[6] = p_hwfn->hw_info.hw_mac_addr[4];
-       guid[7] = p_hwfn->hw_info.hw_mac_addr[5];
-}
-
 static void qed_rdma_init_events(struct qed_hwfn *p_hwfn,
                                 struct qed_rdma_start_in_params *params)
 {
@@ -449,7 +438,9 @@ static void qed_rdma_init_devinfo(struct qed_hwfn *p_hwfn,
        dev->fw_ver = (FW_MAJOR_VERSION << 24) | (FW_MINOR_VERSION << 16) |
                      (FW_REVISION_VERSION << 8) | (FW_ENGINEERING_VERSION);
 
-       qed_rdma_get_guid(p_hwfn, (u8 *)&dev->sys_image_guid);
+       addrconf_addr_eui48((u8 *)&dev->sys_image_guid,
+                           p_hwfn->hw_info.hw_mac_addr);
+
        dev->node_guid = dev->sys_image_guid;
 
        dev->max_sge = min_t(u32, RDMA_MAX_SGE_PER_SQ_WQE,