iio: temperature: mlx90632 Change return value of sensor measurement channel
authorCrt Mori <cmo@melexis.com>
Thu, 22 Sep 2022 08:13:24 +0000 (10:13 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 23 Nov 2022 19:43:57 +0000 (19:43 +0000)
The current EINVAL value is more applicable to embedded library, where
user can actually put the fixed value to the sensor. In case of the
driver if the value of the channel is invalid it is better in inform
userspace that Channel was out of range as that implies more to internal
driver error than invalid input. It also makes for easier debugging of
where the error comes from during the development.

Signed-off-by: Crt Mori <cmo@melexis.com>
Link: https://lore.kernel.org/r/565d4df2592d751dc0f40908f2569b7c9af8e56e.1663834141.git.cmo@melexis.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/temperature/mlx90632.c

index 08180394026168ee13a0cfc1e575b7bbe5d188a4..224db7513baa7a9da5f08bae9c96b7bd84df2f86 100644 (file)
@@ -435,7 +435,7 @@ static int mlx90632_channel_new_select(int perform_ret, uint8_t *channel_new,
                *channel_old = 1;
                break;
        default:
-               return -EINVAL;
+               return -ECHRNG;
        }
 
        return 0;