s390/vmlogrdr: Make use of iucv_alloc_device()

Make use of iucv_alloc_device() to get rid of quite some code. In addition
this also removes a cast to an incompatible function (clang W=1):

  drivers/s390/char/vmlogrdr.c:746:18: error: cast from 'void (*)(const void *)' to 'void (*)(struct device *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
    746 |                 dev->release = (void (*)(struct device *))kfree;
        |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://lore.kernel.org/r/20240417-s390-drivers-fix-cast-function-type-v1-1-fd048c9903b0@kernel.org
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Link: https://lore.kernel.org/r/20240506194454.1160315-3-hca@linux.ibm.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>

diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c
index d7e408c8d0b84a067383ab697ebf4305013679a8..c09e1e09fb66aaab059f6704316a1aa2c0fda718 100644 (file)
--- a/drivers/s390/char/vmlogrdr.c
+++ b/drivers/s390/char/vmlogrdr.c
@@ -728,23 +728,9 @@ static int vmlogrdr_register_device(struct vmlogrdr_priv_t *priv)
        struct device *dev;
        int ret;
 
-       dev = kzalloc(sizeof(struct device), GFP_KERNEL);
-       if (dev) {
-               dev_set_name(dev, "%s", priv->internal_name);
-               dev->bus = &iucv_bus;
-               dev->parent = iucv_root;
-               dev->driver = &vmlogrdr_driver;
-               dev->groups = vmlogrdr_attr_groups;
-               dev_set_drvdata(dev, priv);
-               /*
-                * The release function could be called after the
-                * module has been unloaded. It's _only_ task is to
-                * free the struct. Therefore, we specify kfree()
-                * directly here. (Probably a little bit obfuscating
-                * but legitime ...).
-                */
-               dev->release = (void (*)(struct device *))kfree;
-       } else
+       dev = iucv_alloc_device(vmlogrdr_attr_groups, &vmlogrdr_driver,
+                               priv, priv->internal_name);
+       if (!dev)
                return -ENOMEM;
        ret = device_register(dev);
        if (ret) {