cpufreq: scmi: Avoid one OF parsing in scmi_get_sharing_cpus()
authorUlf Hansson <ulf.hansson@linaro.org>
Fri, 25 Aug 2023 11:26:26 +0000 (13:26 +0200)
committerSudeep Holla <sudeep.holla@arm.com>
Thu, 21 Sep 2023 15:24:27 +0000 (16:24 +0100)
The domain-id for the cpu_dev has already been parsed at the point when
scmi_get_sharing_cpus() is getting called. Let's pass it as an in-parameter
to avoid the unnecessary OF parsing.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20230825112633.236607-7-ulf.hansson@linaro.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/cpufreq/scmi-cpufreq.c

index 125e8a8421fb9076dcaa0bbb18365c20625abfef..78f53e3880941e0f35aa871c624f2be1d47c0641 100644 (file)
@@ -82,15 +82,12 @@ static int scmi_cpu_domain_id(struct device *cpu_dev)
 }
 
 static int
-scmi_get_sharing_cpus(struct device *cpu_dev, struct cpumask *cpumask)
+scmi_get_sharing_cpus(struct device *cpu_dev, int domain,
+                     struct cpumask *cpumask)
 {
-       int cpu, domain, tdomain;
+       int cpu, tdomain;
        struct device *tcpu_dev;
 
-       domain = scmi_cpu_domain_id(cpu_dev);
-       if (domain < 0)
-               return domain;
-
        for_each_possible_cpu(cpu) {
                if (cpu == cpu_dev->id)
                        continue;
@@ -163,7 +160,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
        }
 
        /* Obtain CPUs that share SCMI performance controls */
-       ret = scmi_get_sharing_cpus(cpu_dev, policy->cpus);
+       ret = scmi_get_sharing_cpus(cpu_dev, domain, policy->cpus);
        if (ret) {
                dev_warn(cpu_dev, "failed to get sharing cpumask\n");
                goto out_free_cpumask;