net: ena: Make queue stats code cleaner by removing the if block
authorDavid Arinzon <darinzon@amazon.com>
Mon, 1 Jan 2024 19:08:54 +0000 (19:08 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Jan 2024 02:00:58 +0000 (18:00 -0800)
Also shorten comment related to it.

Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: David Arinzon <darinzon@amazon.com>
Link: https://lore.kernel.org/r/20240101190855.18739-11-darinzon@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amazon/ena/ena_ethtool.c

index 724af7dfefae00f05ccbfb95462501944a31218e..0cb6cc1cef566221b50e29519682756a22c39496 100644 (file)
@@ -263,17 +263,14 @@ static void ena_queue_strings(struct ena_adapter *adapter, u8 **data)
                                        ena_stats->name);
                }
 
-               if (!is_xdp) {
-                       /* RX stats, in XDP there isn't a RX queue
-                        * counterpart
-                        */
-                       for (j = 0; j < ENA_STATS_ARRAY_RX; j++) {
-                               ena_stats = &ena_stats_rx_strings[j];
+               /* In XDP there isn't an RX queue counterpart */
+               if (is_xdp)
+                       continue;
 
-                               ethtool_sprintf(data,
-                                               "queue_%u_rx_%s", i,
-                                               ena_stats->name);
-                       }
+               for (j = 0; j < ENA_STATS_ARRAY_RX; j++) {
+                       ena_stats = &ena_stats_rx_strings[j];
+
+                       ethtool_sprintf(data, "queue_%u_rx_%s", i, ena_stats->name);
                }
        }
 }