wifi: wl3501_cs: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 15:04:53 +0000 (23:04 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:39:08 +0000 (09:39 +0100)
[ Upstream commit 44bacbdf9066c590423259dbd6d520baac99c1a8 ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150453.114742-1-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/wl3501_cs.c

index 672f5d5f3f2c7fceaf4d9f2d2cc1bfa05f96eb68..cb71b73853f4e09f0eee299c51b1e98115d9ec73 100644 (file)
@@ -1328,7 +1328,7 @@ static netdev_tx_t wl3501_hard_start_xmit(struct sk_buff *skb,
        } else {
                ++dev->stats.tx_packets;
                dev->stats.tx_bytes += skb->len;
-               kfree_skb(skb);
+               dev_kfree_skb_irq(skb);
 
                if (this->tx_buffer_cnt < 2)
                        netif_stop_queue(dev);