spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
authorRajeshwar R Shinde <coolrrsh@gmail.com>
Mon, 7 Aug 2023 14:49:42 +0000 (20:19 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 7 Aug 2023 17:37:54 +0000 (18:37 +0100)
In struct mpc52xx_psc_spi, the variable 'irq' is declared as an unsigned int.
The comparison of variable 'irq'  with signed int operand is incorrect. Also,
the return value from the call to platform_get_irq(pdev,0) is int and it is
assigned to an unsigned int variable 'irq', thus redeclaring the type of
variable 'irq' to signed int.

This fixes warning such as:
drivers/spi/spi-mpc52xx-psc.c:332:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0

Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
Link: https://lore.kernel.org/r/20230807144942.30317-2-coolrrsh@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mpc52xx-psc.c

index 9a1a080fb688c2b8a4551380a8ec72fc2a2e9d4f..795c08594a4dbef1c3e1f9ce267a19082cd0a2c6 100644 (file)
@@ -29,7 +29,7 @@ struct mpc52xx_psc_spi {
        /* driver internal data */
        struct mpc52xx_psc __iomem *psc;
        struct mpc52xx_psc_fifo __iomem *fifo;
-       unsigned int irq;
+       int irq;
        u8 bits_per_word;
 
        struct completion done;