drm/nouveau/devinit/tu102-: wait for GFW_BOOT_PROGRESS == COMPLETED
authorBen Skeggs <bskeggs@redhat.com>
Mon, 30 Jan 2023 22:37:13 +0000 (08:37 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:57:02 +0000 (12:57 +0100)
[ Upstream commit d22915d22ded21fd5b24b60d174775789f173997 ]

Starting from Turing, the driver is no longer responsible for initiating
DEVINIT when required as the GPU started loading a FW image from ROM and
executing DEVINIT itself after power-on.

However - we apparently still need to wait for it to complete.

This should correct some issues with runpm on some systems, where we get
control of the HW before it's been fully reinitialised after resume from
suspend.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230130223715.1831509-1-bskeggs@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/tu102.c

index 634f64f88fc8be391f3efba4e0ff8744eed9e94c..81a1ad2c88a7e2887f561f6eca81c68351eb0c62 100644 (file)
@@ -65,10 +65,33 @@ tu102_devinit_pll_set(struct nvkm_devinit *init, u32 type, u32 freq)
        return ret;
 }
 
+static int
+tu102_devinit_wait(struct nvkm_device *device)
+{
+       unsigned timeout = 50 + 2000;
+
+       do {
+               if (nvkm_rd32(device, 0x118128) & 0x00000001) {
+                       if ((nvkm_rd32(device, 0x118234) & 0x000000ff) == 0xff)
+                               return 0;
+               }
+
+               usleep_range(1000, 2000);
+       } while (timeout--);
+
+       return -ETIMEDOUT;
+}
+
 int
 tu102_devinit_post(struct nvkm_devinit *base, bool post)
 {
        struct nv50_devinit *init = nv50_devinit(base);
+       int ret;
+
+       ret = tu102_devinit_wait(init->base.subdev.device);
+       if (ret)
+               return ret;
+
        gm200_devinit_preos(init, post);
        return 0;
 }