iio:light:us5182d: Improve error reporting for problems during .remove()

Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are
called.

So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic
message.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220515155929.338656-7-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/light/us5182d.c b/drivers/iio/light/us5182d.c
index 1492aaf8d84cfe55ab93515666bcc696cebb3d8c..cbd9978540fa546657a6d4feb0ea2799e551cdf5 100644 (file)
--- a/drivers/iio/light/us5182d.c
+++ b/drivers/iio/light/us5182d.c
@@ -907,13 +907,19 @@ out_err:
 static int us5182d_remove(struct i2c_client *client)
 {
        struct us5182d_data *data = iio_priv(i2c_get_clientdata(client));
+       int ret;
 
        iio_device_unregister(i2c_get_clientdata(client));
 
        pm_runtime_disable(&client->dev);
        pm_runtime_set_suspended(&client->dev);
 
-       return us5182d_shutdown_en(data, US5182D_CFG0_SHUTDOWN_EN);
+       ret = us5182d_shutdown_en(data, US5182D_CFG0_SHUTDOWN_EN);
+       if (ret)
+               dev_warn(&client->dev, "Failed to shut down (%pe)\n",
+                        ERR_PTR(ret));
+
+       return 0;
 }
 
 #if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM)