scsi: hpsa: Fix allocation size for Scsi_Host private data
authorYuri Karpov <YKarpov@ispras.ru>
Tue, 12 Mar 2024 17:04:47 +0000 (20:04 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 20 Apr 2024 14:55:12 +0000 (10:55 -0400)
struct Scsi_Host private data contains pointer to struct ctlr_info.

Restore allocation of only 8 bytes to store pointer in struct Scsi_Host
private data area.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: bbbd25499100 ("scsi: hpsa: Fix allocation size for scsi_host_alloc()")
Signed-off-by: Yuri Karpov <YKarpov@ispras.ru>
Link: https://lore.kernel.org/r/20240312170447.743709-1-YKarpov@ispras.ru
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hpsa.c

index af18d20f30794bff0b3702f748482215e7883792..49c57a9c110b5fdf623a2da67031c6e719b21def 100644 (file)
@@ -5850,7 +5850,7 @@ static int hpsa_scsi_host_alloc(struct ctlr_info *h)
 {
        struct Scsi_Host *sh;
 
-       sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info));
+       sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info *));
        if (sh == NULL) {
                dev_err(&h->pdev->dev, "scsi_host_alloc failed\n");
                return -ENOMEM;