serial: esp32_acm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231110152927.70601-14-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/esp32_acm.c b/drivers/tty/serial/esp32_acm.c
index cb28a87736aa1b817c3efb06337bc9a3ae4d1db6..a4cbaedb51702d500c26e8cf85ceb48054ccc951 100644 (file)
--- a/drivers/tty/serial/esp32_acm.c
+++ b/drivers/tty/serial/esp32_acm.c
@@ -413,18 +413,17 @@ static int esp32s3_acm_probe(struct platform_device *pdev)
        return uart_add_one_port(&esp32s3_acm_reg, port);
 }
 
-static int esp32s3_acm_remove(struct platform_device *pdev)
+static void esp32s3_acm_remove(struct platform_device *pdev)
 {
        struct uart_port *port = platform_get_drvdata(pdev);
 
        uart_remove_one_port(&esp32s3_acm_reg, port);
-       return 0;
 }
 
 
 static struct platform_driver esp32s3_acm_driver = {
        .probe          = esp32s3_acm_probe,
-       .remove         = esp32s3_acm_remove,
+       .remove_new     = esp32s3_acm_remove,
        .driver         = {
                .name   = DRIVER_NAME,
                .of_match_table = esp32s3_acm_dt_ids,