i2c: tegra: use i2c_timings for bus clock freq
authorAkhil R <akhilrajeev@nvidia.com>
Fri, 10 Dec 2021 12:15:57 +0000 (17:45 +0530)
committerWolfram Sang <wsa@kernel.org>
Fri, 10 Dec 2021 21:23:05 +0000 (22:23 +0100)
Use i2c_timings struct and corresponding methods to get bus clock frequency

Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-tegra.c

index 56c9c02821c2c5634be6245825258bdbc8f352ea..03cea102ab76d171a1260a7520b46357b3502c4d 100644 (file)
@@ -246,7 +246,7 @@ struct tegra_i2c_hw_feature {
  * @msg_buf: pointer to current message data
  * @msg_buf_remaining: size of unsent data in the message buffer
  * @msg_read: indicates that the transfer is a read access
- * @bus_clk_rate: current I2C bus clock rate
+ * @timings: i2c timings information like bus frequency
  * @multimaster_mode: indicates that I2C controller is in multi-master mode
  * @tx_dma_chan: DMA transmit channel
  * @rx_dma_chan: DMA receive channel
@@ -273,7 +273,7 @@ struct tegra_i2c_dev {
        unsigned int nclocks;
 
        struct clk *div_clk;
-       u32 bus_clk_rate;
+       struct i2c_timings timings;
 
        struct completion msg_complete;
        size_t msg_buf_remaining;
@@ -610,6 +610,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
 {
        u32 val, clk_divisor, clk_multiplier, tsu_thd, tlow, thigh, non_hs_mode;
        acpi_handle handle = ACPI_HANDLE(i2c_dev->dev);
+       struct i2c_timings *t = &i2c_dev->timings;
        int err;
 
        /*
@@ -642,14 +643,14 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
        if (i2c_dev->is_vi)
                tegra_i2c_vi_init(i2c_dev);
 
-       switch (i2c_dev->bus_clk_rate) {
+       switch (t->bus_freq_hz) {
        case I2C_MAX_STANDARD_MODE_FREQ + 1 ... I2C_MAX_FAST_MODE_PLUS_FREQ:
        default:
                tlow = i2c_dev->hw->tlow_fast_fastplus_mode;
                thigh = i2c_dev->hw->thigh_fast_fastplus_mode;
                tsu_thd = i2c_dev->hw->setup_hold_time_fast_fast_plus_mode;
 
-               if (i2c_dev->bus_clk_rate > I2C_MAX_FAST_MODE_FREQ)
+               if (t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ)
                        non_hs_mode = i2c_dev->hw->clk_divisor_fast_plus_mode;
                else
                        non_hs_mode = i2c_dev->hw->clk_divisor_fast_mode;
@@ -685,7 +686,7 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev)
        clk_multiplier = (tlow + thigh + 2) * (non_hs_mode + 1);
 
        err = clk_set_rate(i2c_dev->div_clk,
-                          i2c_dev->bus_clk_rate * clk_multiplier);
+                          t->bus_freq_hz * clk_multiplier);
        if (err) {
                dev_err(i2c_dev->dev, "failed to set div-clk rate: %d\n", err);
                return err;
@@ -724,7 +725,7 @@ static int tegra_i2c_disable_packet_mode(struct tegra_i2c_dev *i2c_dev)
         * before disabling the controller so that the STOP condition has
         * been delivered properly.
         */
-       udelay(DIV_ROUND_UP(2 * 1000000, i2c_dev->bus_clk_rate));
+       udelay(DIV_ROUND_UP(2 * 1000000, i2c_dev->timings.bus_freq_hz));
 
        cnfg = i2c_readl(i2c_dev, I2C_CNFG);
        if (cnfg & I2C_CNFG_PACKET_MODE_EN)
@@ -1254,7 +1255,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
         * Total bits = 9 bits per byte (including ACK bit) + Start & stop bits
         */
        xfer_time += DIV_ROUND_CLOSEST(((xfer_size * 9) + 2) * MSEC_PER_SEC,
-                                      i2c_dev->bus_clk_rate);
+                                      i2c_dev->timings.bus_freq_hz);
 
        int_mask = I2C_INT_NO_ACK | I2C_INT_ARBITRATION_LOST;
        tegra_i2c_unmask_irq(i2c_dev, int_mask);
@@ -1631,12 +1632,8 @@ static void tegra_i2c_parse_dt(struct tegra_i2c_dev *i2c_dev)
 {
        struct device_node *np = i2c_dev->dev->of_node;
        bool multi_mode;
-       int err;
 
-       err = device_property_read_u32(i2c_dev->dev, "clock-frequency",
-                                      &i2c_dev->bus_clk_rate);
-       if (err)
-               i2c_dev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ;
+       i2c_parse_fw_timings(i2c_dev->dev, &i2c_dev->timings, true);
 
        multi_mode = device_property_read_bool(i2c_dev->dev, "multi-master");
        i2c_dev->multimaster_mode = multi_mode;