staging: wfx: simplify wfx_flush()
authorJérôme Pouiller <jerome.pouiller@silabs.com>
Wed, 15 Jan 2020 13:54:30 +0000 (13:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Jan 2020 19:59:48 +0000 (20:59 +0100)
Current code of wfx_flush() force to drop packets in some contexts.
However, there is no obvious reasons to do that. It looks like a
workaround for a bug with the old implementation of __wfx_flush().

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200115135338.14374-21-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/sta.c

index 3d665eef8ba791c5a13df9999a8a8e53ec9ee535..ae01f7be0ddba198054b3a2b2e94313fcfdf1398 100644 (file)
@@ -362,17 +362,7 @@ static int __wfx_flush(struct wfx_dev *wdev, bool drop)
 void wfx_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
                  u32 queues, bool drop)
 {
-       struct wfx_vif *wvif;
-
-       if (vif) {
-               wvif = (struct wfx_vif *) vif->drv_priv;
-               if (wvif->vif->type == NL80211_IFTYPE_MONITOR)
-                       drop = true;
-               if (wvif->vif->type == NL80211_IFTYPE_AP &&
-                   !wvif->enable_beacon)
-                       drop = true;
-       }
-       // FIXME: only flush requested vif
+       // FIXME: only flush requested vif and queues
        __wfx_flush(hw->priv, drop);
 }