habanalabs: allow unregistering eventfd when device non-operational
authorTomer Tayar <ttayar@habana.ai>
Fri, 30 Sep 2022 11:19:21 +0000 (14:19 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Wed, 23 Nov 2022 14:13:40 +0000 (16:13 +0200)
Unregistering eventfd is for releasing host resources and doesn't
involve an access to the device. As such, there is no reason to disallow
it when device isn't operational.

Signed-off-by: Tomer Tayar <ttayar@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/misc/habanalabs/common/habanalabs_ioctl.c

index cac2c7fb14f1b59386a1015c7ec0e7fb939de044..5ce5c42e273136c88ec8927579193aaa6098efd6 100644 (file)
@@ -879,6 +879,9 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data,
        case HL_INFO_USER_MAPPINGS:
                return user_mappings_info(hpriv, args);
 
+       case HL_INFO_UNREGISTER_EVENTFD:
+               return eventfd_unregister(hpriv, args);
+
        default:
                break;
        }
@@ -935,9 +938,6 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data,
        case HL_INFO_REGISTER_EVENTFD:
                return eventfd_register(hpriv, args);
 
-       case HL_INFO_UNREGISTER_EVENTFD:
-               return eventfd_unregister(hpriv, args);
-
        case HL_INFO_ENGINE_STATUS:
                return engine_status_info(hpriv, args);