staging: r8188eu: remove LedControlHandler
authorMartin Kaiser <martin@kaiser.cx>
Sun, 26 Dec 2021 19:55:49 +0000 (20:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Dec 2021 16:12:34 +0000 (17:12 +0100)
Export the function that other layers use for setting the led.

Remove the function pointer and the macro to make the led control function
configurable. This driver supports only a single configuration.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211226195556.159471-15-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c
drivers/staging/r8188eu/include/rtw_led.h

index 8223bddc490bc0aac1f8f99a598a35bcac9e74ae..86c6c1a3b8bfd3a3cdaf7db2f4581e9524df5cef 100644 (file)
@@ -411,8 +411,6 @@ void rtl8188eu_InitSwLeds(struct adapter *padapter)
        struct led_priv *pledpriv = &padapter->ledpriv;
        struct LED_871x *pLed = &pledpriv->SwLed0;
 
-       pledpriv->LedControlHandler = LedControl8188eu;
-
        pLed->padapter = padapter;
        ResetLedStatus(pLed);
        INIT_DELAYED_WORK(&pLed->blink_work, blink_work);
@@ -428,7 +426,7 @@ void rtl8188eu_DeInitSwLeds(struct adapter *padapter)
        SwLedOff(padapter, pLed);
 }
 
-void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE LedAction)
+void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
 {
        struct led_priv *ledpriv = &padapter->ledpriv;
        struct registry_priv *registry_par;
index 2672ab16578483f3b94a70bc8ad542d16e23c008..5c7b33e707329bfdbdbfe91969aa0b7f161379f5 100644 (file)
@@ -60,22 +60,14 @@ struct LED_871x {
        struct delayed_work blink_work;
 };
 
-void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE      LedAction);
-
 struct led_priv{
        struct LED_871x                 SwLed0;
        bool    bRegUseLed;
-       void (*LedControlHandler)(struct adapter *padapter,
-                                 enum LED_CTL_MODE LedAction);
 };
 
-#define rtw_led_control(adapt, action) \
-       do { \
-               if ((adapt)->ledpriv.LedControlHandler) \
-                       (adapt)->ledpriv.LedControlHandler((adapt), (action)); \
-       } while (0)
-
 void rtl8188eu_InitSwLeds(struct adapter *padapter);
 void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
 
+void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction);
+
 #endif /* __RTW_LED_H_ */