net: marvell: prestera: fix memory leak in prestera_rxtx_switch_init()

When prestera_sdma_switch_init() failed, the memory pointed to by
sw->rxtx isn't released. Fix it. Only be compiled, not be tested.

Fixes: 501ef3066c89 ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Vadym Kochan <vadym.kochan@plvision.eu>
Link: https://lore.kernel.org/r/20221108025607.338450-1-shaozhengchao@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c b/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
index 42ee963e9f75967a2392defa36f60baef4a2de3d..9277a8fd1339dc60049c437b933ed3a0b3042c69 100644 (file)
--- a/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
@@ -776,6 +776,7 @@ tx_done:
 int prestera_rxtx_switch_init(struct prestera_switch *sw)
 {
        struct prestera_rxtx *rxtx;
+       int err;
 
        rxtx = kzalloc(sizeof(*rxtx), GFP_KERNEL);
        if (!rxtx)
@@ -783,7 +784,11 @@ int prestera_rxtx_switch_init(struct prestera_switch *sw)
 
        sw->rxtx = rxtx;
 
-       return prestera_sdma_switch_init(sw);
+       err = prestera_sdma_switch_init(sw);
+       if (err)
+               kfree(rxtx);
+
+       return err;
 }
 
 void prestera_rxtx_switch_fini(struct prestera_switch *sw)