spi: fsl-dspi: Unify error messaging in dspi_request_dma()

Use dev_err_probe() for all messages in dspi_request_dma() for the sake of
making them uniform. While at it, fix indentation issue reported by Vladimir
Oltean.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20240204203127.1186621-3-andy.shevchenko@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 0b5ea7a7da7199b01ce5179e55cc25b82b3707a6..38defdcf9370a3dfee953f44891fb07b87f0e155 100644 (file)
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -502,15 +502,12 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
                return -ENOMEM;
 
        dma->chan_rx = dma_request_chan(dev, "rx");
-       if (IS_ERR(dma->chan_rx)) {
-               return dev_err_probe(dev, PTR_ERR(dma->chan_rx),
-                       "rx dma channel not available\n");
-       }
+       if (IS_ERR(dma->chan_rx))
+               return dev_err_probe(dev, PTR_ERR(dma->chan_rx), "rx dma channel not available\n");
 
        dma->chan_tx = dma_request_chan(dev, "tx");
        if (IS_ERR(dma->chan_tx)) {
-               ret = PTR_ERR(dma->chan_tx);
-               dev_err_probe(dev, ret, "tx dma channel not available\n");
+               ret = dev_err_probe(dev, PTR_ERR(dma->chan_tx), "tx dma channel not available\n");
                goto err_tx_channel;
        }
 
@@ -541,14 +538,14 @@ static int dspi_request_dma(struct fsl_dspi *dspi, phys_addr_t phy_addr)
        cfg.direction = DMA_DEV_TO_MEM;
        ret = dmaengine_slave_config(dma->chan_rx, &cfg);
        if (ret) {
-               dev_err(dev, "can't configure rx dma channel\n");
+               dev_err_probe(dev, ret, "can't configure rx dma channel\n");
                goto err_slave_config;
        }
 
        cfg.direction = DMA_MEM_TO_DEV;
        ret = dmaengine_slave_config(dma->chan_tx, &cfg);
        if (ret) {
-               dev_err(dev, "can't configure tx dma channel\n");
+               dev_err_probe(dev, ret, "can't configure tx dma channel\n");
                goto err_slave_config;
        }