perf hists browser: Reorder variables to reduce padding
authorIan Rogers <irogers@google.com>
Mon, 9 Oct 2023 18:39:12 +0000 (11:39 -0700)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 12 Oct 2023 17:01:56 +0000 (10:01 -0700)
Address clang-tidy warning:
```
tools/perf/ui/browsers/hists.c:2416:8: warning: Excessive padding in 'struct popup_action' (8 padding bytes, where 0 is optimal).
Optimal fields order:
time,
thread,
evsel,
fn,
ms,
socket,
rstype,
```

Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: llvm@lists.linux.dev
Cc: Ming Wang <wangming01@loongson.cn>
Cc: Tom Rix <trix@redhat.com>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20231009183920.200859-12-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/ui/browsers/hists.c

index 70db5a717905692f4f339712e5adc10f37bafedc..f02ee605bbced761825303716e7edc3c6c7bcf17 100644 (file)
@@ -2416,12 +2416,12 @@ close_file_and_continue:
 struct popup_action {
        unsigned long           time;
        struct thread           *thread;
+       struct evsel    *evsel;
+       int (*fn)(struct hist_browser *browser, struct popup_action *act);
        struct map_symbol       ms;
        int                     socket;
-       struct evsel    *evsel;
        enum rstype             rstype;
 
-       int (*fn)(struct hist_browser *browser, struct popup_action *act);
 };
 
 static int