platform/x86: samsung-laptop: Use sysfs_emit() to replace the old interface sprintf()
authoryunshui <jiangyunshui@kylinos.cn>
Fri, 19 Apr 2024 06:41:06 +0000 (14:41 +0800)
committerHans de Goede <hdegoede@redhat.com>
Mon, 29 Apr 2024 08:52:03 +0000 (10:52 +0200)
    As Documentation/filesystems/sysfs.rst suggested,
    show() should only use sysfs_emit() or sysfs_emit_at() when formatting
    the value to be returned to user space.

Signed-off-by: yunshui <jiangyunshui@kylinos.cn>
Reviewed-by: Ai Chao <aichao@kylinos.cn>
Link: https://lore.kernel.org/r/20240419064106.2396705-1-jiangyunshui@kylinos.cn
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/samsung-laptop.c

index b4aa8ba35d2d7df1be52ab171f4facf61e1fedf7..3d2f8e758369d88c1293c4f25d5bcc3738505984 100644 (file)
@@ -661,9 +661,9 @@ static ssize_t get_performance_level(struct device *dev,
        /* The logic is backwards, yeah, lots of fun... */
        for (i = 0; config->performance_levels[i].name; ++i) {
                if (sretval.data[0] == config->performance_levels[i].value)
-                       return sprintf(buf, "%s\n", config->performance_levels[i].name);
+                       return sysfs_emit(buf, "%s\n", config->performance_levels[i].name);
        }
-       return sprintf(buf, "%s\n", "unknown");
+       return sysfs_emit(buf, "%s\n", "unknown");
 }
 
 static ssize_t set_performance_level(struct device *dev,
@@ -744,7 +744,7 @@ static ssize_t get_battery_life_extender(struct device *dev,
        if (ret < 0)
                return ret;
 
-       return sprintf(buf, "%d\n", ret);
+       return sysfs_emit(buf, "%d\n", ret);
 }
 
 static ssize_t set_battery_life_extender(struct device *dev,
@@ -813,7 +813,7 @@ static ssize_t get_usb_charge(struct device *dev,
        if (ret < 0)
                return ret;
 
-       return sprintf(buf, "%d\n", ret);
+       return sysfs_emit(buf, "%d\n", ret);
 }
 
 static ssize_t set_usb_charge(struct device *dev,
@@ -878,7 +878,7 @@ static ssize_t get_lid_handling(struct device *dev,
        if (ret < 0)
                return ret;
 
-       return sprintf(buf, "%d\n", ret);
+       return sysfs_emit(buf, "%d\n", ret);
 }
 
 static ssize_t set_lid_handling(struct device *dev,