usb: host: fotg210-hcd: Remove unused variable 'hcc_params'
authorLee Jones <lee.jones@linaro.org>
Mon, 6 Jul 2020 13:33:27 +0000 (14:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jul 2020 15:19:58 +0000 (17:19 +0200)
The result is actually read into fotg210->caps->hcc_params.  No
need to popuate an unused varible with the unchecked return value
from fotg210_readl().

Fixes the following W=1 kernel build warning(s):

 drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’:
 drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable]
 5013 | u32 hcc_params;
 | ^~~~~~~~~~

Cc: Yuan-Hsin Chen <yhchen@faraday-tech.com>
Cc: Feng-Hsin Chiang <john453@faraday-tech.com>
Cc: Po-Yu Chuang <ratbert.chuang@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20200706133341.476881-19-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/fotg210-hcd.c

index f967adf2d8dfcfe8dcc140c946845125c12e4972..51dbbb0e768bc6818608a34ef5fdfe478a9d3568 100644 (file)
@@ -5010,7 +5010,6 @@ static int fotg210_run(struct usb_hcd *hcd)
 {
        struct fotg210_hcd *fotg210 = hcd_to_fotg210(hcd);
        u32 temp;
-       u32 hcc_params;
 
        hcd->uses_new_polling = 1;
 
@@ -5033,7 +5032,7 @@ static int fotg210_run(struct usb_hcd *hcd)
         * Scsi_Host.highmem_io, and so forth.  It's readonly to all
         * host side drivers though.
         */
-       hcc_params = fotg210_readl(fotg210, &fotg210->caps->hcc_params);
+       fotg210_readl(fotg210, &fotg210->caps->hcc_params);
 
        /*
         * Philips, Intel, and maybe others need CMD_RUN before the