{
        struct rome_config config;
        int err;
-       u8 rom_ver;
+       u8 rom_ver = 0;
 
        bt_dev_dbg(hdev, "QCA setup on UART");
 
 
        /* Download rampatch file */
        config.type = TLV_TYPE_PATCH;
-       if (soc_type == QCA_WCN3990) {
+       if (qca_is_wcn399x(soc_type)) {
                /* Firmware files to download are based on ROM version.
                 * ROM version is derived from last two bytes of soc_ver.
                 */
 
        /* Download NVM configuration */
        config.type = TLV_TYPE_NVM;
-       if (soc_type == QCA_WCN3990)
+       if (qca_is_wcn399x(soc_type))
                snprintf(config.fwname, sizeof(config.fwname),
                         "qca/crnv%02x.bin", rom_ver);
        else
 }
 EXPORT_SYMBOL_GPL(qca_set_bdaddr);
 
+
 MODULE_AUTHOR("Ben Young Tae Kim <ytkim@qca.qualcomm.com>");
 MODULE_DESCRIPTION("Bluetooth support for Qualcomm Atheros family ver " VERSION);
 MODULE_VERSION(VERSION);
 
        if (hu->serdev) {
 
                qcadev = serdev_device_get_drvdata(hu->serdev);
-               if (qcadev->btsoc_type != QCA_WCN3990) {
+               if (!qca_is_wcn399x(qcadev->btsoc_type)) {
                        gpiod_set_value_cansleep(qcadev->bt_en, 1);
                        /* Controller needs time to bootup. */
                        msleep(150);
 
        if (hu->serdev) {
                qcadev = serdev_device_get_drvdata(hu->serdev);
-               if (qcadev->btsoc_type == QCA_WCN3990)
+               if (qca_is_wcn399x(qcadev->btsoc_type))
                        qca_power_shutdown(hu);
                else
                        gpiod_set_value_cansleep(qcadev->bt_en, 0);
                      msecs_to_jiffies(CMD_TRANS_TIMEOUT_MS));
 
        /* Give the controller time to process the request */
-       if (qca_soc_type(hu) == QCA_WCN3990)
+       if (qca_is_wcn399x(qca_soc_type(hu)))
                msleep(10);
        else
                msleep(300);
 
 static int qca_check_speeds(struct hci_uart *hu)
 {
-       if (qca_soc_type(hu) == QCA_WCN3990) {
+       if (qca_is_wcn399x(qca_soc_type(hu))) {
                if (!qca_get_speed(hu, QCA_INIT_SPEED) &&
                    !qca_get_speed(hu, QCA_OPER_SPEED))
                        return -EINVAL;
                /* Disable flow control for wcn3990 to deassert RTS while
                 * changing the baudrate of chip and host.
                 */
-               if (soc_type == QCA_WCN3990)
+               if (qca_is_wcn399x(soc_type))
                        hci_uart_set_flow_control(hu, true);
 
                qca_baudrate = qca_get_baudrate_value(speed);
                host_set_baudrate(hu, speed);
 
 error:
-               if (soc_type == QCA_WCN3990)
+               if (qca_is_wcn399x(soc_type))
                        hci_uart_set_flow_control(hu, false);
        }
 
        /* Patch downloading has to be done without IBS mode */
        clear_bit(STATE_IN_BAND_SLEEP_ENABLED, &qca->flags);
 
-       if (soc_type == QCA_WCN3990) {
+       if (qca_is_wcn399x(soc_type)) {
                bt_dev_info(hdev, "setting up wcn3990");
 
                /* Enable NON_PERSISTENT_SETUP QUIRK to ensure to execute
                qca_baudrate = qca_get_baudrate_value(speed);
        }
 
-       if (soc_type != QCA_WCN3990) {
+       if (!qca_is_wcn399x(soc_type)) {
                /* Get QCA version information */
                ret = qca_read_soc_version(hdev, &soc_ver);
                if (ret)
        }
 
        /* Setup bdaddr */
-       if (soc_type == QCA_WCN3990)
+       if (qca_is_wcn399x(soc_type))
                hu->hdev->set_bdaddr = qca_set_bdaddr;
        else
                hu->hdev->set_bdaddr = qca_set_bdaddr_rome;
        .dequeue        = qca_dequeue,
 };
 
-static const struct qca_vreg_data qca_soc_data = {
+static const struct qca_vreg_data qca_soc_data_wcn3990 = {
        .soc_type = QCA_WCN3990,
        .vregs = (struct qca_vreg []) {
                { "vddio",   1800000, 1900000,  15000  },
        .num_vregs = 4,
 };
 
+static const struct qca_vreg_data qca_soc_data_wcn3998 = {
+       .soc_type = QCA_WCN3998,
+       .vregs = (struct qca_vreg []) {
+               { "vddio",   1800000, 1900000,  10000  },
+               { "vddxo",   1800000, 1900000,  80000  },
+               { "vddrf",   1300000, 1352000,  300000 },
+               { "vddch0",  3300000, 3300000,  450000 },
+       },
+       .num_vregs = 4,
+};
+
 static void qca_power_shutdown(struct hci_uart *hu)
 {
        struct qca_data *qca = hu->priv;
        qcadev->serdev_hu.serdev = serdev;
        data = of_device_get_match_data(&serdev->dev);
        serdev_device_set_drvdata(serdev, qcadev);
-       if (data && data->soc_type == QCA_WCN3990) {
-               qcadev->btsoc_type = QCA_WCN3990;
+       if (data && qca_is_wcn399x(data->soc_type)) {
+               qcadev->btsoc_type = data->soc_type;
                qcadev->bt_power = devm_kzalloc(&serdev->dev,
                                                sizeof(struct qca_power),
                                                GFP_KERNEL);
 {
        struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev);
 
-       if (qcadev->btsoc_type == QCA_WCN3990)
+       if (qca_is_wcn399x(qcadev->btsoc_type))
                qca_power_shutdown(&qcadev->serdev_hu);
        else
                clk_disable_unprepare(qcadev->susclk);
 
 static const struct of_device_id qca_bluetooth_of_match[] = {
        { .compatible = "qcom,qca6174-bt" },
-       { .compatible = "qcom,wcn3990-bt", .data = &qca_soc_data},
+       { .compatible = "qcom,wcn3990-bt", .data = &qca_soc_data_wcn3990},
+       { .compatible = "qcom,wcn3998-bt", .data = &qca_soc_data_wcn3998},
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, qca_bluetooth_of_match);