crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possible
authorStefan Berger <stefanb@linux.ibm.com>
Thu, 4 Apr 2024 14:18:44 +0000 (10:18 -0400)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 12 Apr 2024 07:07:51 +0000 (15:07 +0800)
Replace hard-coded numbers with ECC_CURVE_NIST_P192/256/384_DIGITS where
possible.

Tested-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/ecc.c

index 7c960e0d8e431a1d003d850c7ec0215dffeb656d..e94183f6c41867299820af4816db658507f84836 100644 (file)
@@ -689,7 +689,7 @@ static void vli_mmod_barrett(u64 *result, u64 *product, const u64 *mod,
 static void vli_mmod_fast_192(u64 *result, const u64 *product,
                              const u64 *curve_prime, u64 *tmp)
 {
-       const unsigned int ndigits = 3;
+       const unsigned int ndigits = ECC_CURVE_NIST_P192_DIGITS;
        int carry;
 
        vli_set(result, product, ndigits);
@@ -717,7 +717,7 @@ static void vli_mmod_fast_256(u64 *result, const u64 *product,
                              const u64 *curve_prime, u64 *tmp)
 {
        int carry;
-       const unsigned int ndigits = 4;
+       const unsigned int ndigits = ECC_CURVE_NIST_P256_DIGITS;
 
        /* t */
        vli_set(result, product, ndigits);
@@ -800,7 +800,7 @@ static void vli_mmod_fast_384(u64 *result, const u64 *product,
                                const u64 *curve_prime, u64 *tmp)
 {
        int carry;
-       const unsigned int ndigits = 6;
+       const unsigned int ndigits = ECC_CURVE_NIST_P384_DIGITS;
 
        /* t */
        vli_set(result, product, ndigits);
@@ -932,13 +932,13 @@ static bool vli_mmod_fast(u64 *result, u64 *product,
        }
 
        switch (ndigits) {
-       case 3:
+       case ECC_CURVE_NIST_P192_DIGITS:
                vli_mmod_fast_192(result, product, curve_prime, tmp);
                break;
-       case 4:
+       case ECC_CURVE_NIST_P256_DIGITS:
                vli_mmod_fast_256(result, product, curve_prime, tmp);
                break;
-       case 6:
+       case ECC_CURVE_NIST_P384_DIGITS:
                vli_mmod_fast_384(result, product, curve_prime, tmp);
                break;
        default: