media: videobuf2: Remove duplicated index vs q->num_buffers check
authorBenjamin Gaignard <benjamin.gaignard@collabora.com>
Thu, 9 Nov 2023 16:29:18 +0000 (17:29 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 23 Nov 2023 10:55:19 +0000 (11:55 +0100)
vb2_get_buffer() already checks if the requested index is valid.
Stop duplicating this kind of check everywhere.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/common/videobuf2/videobuf2-v4l2.c

index 37f814a89ace69cf294db0cbe6551f79b4bc1c59..6ba13a95323c1303320dcc2f8da879e403c12199 100644 (file)
@@ -817,10 +817,6 @@ int vb2_qbuf(struct vb2_queue *q, struct media_device *mdev,
                return -EBUSY;
        }
 
-       if (b->index >= q->num_buffers) {
-               dprintk(q, 1, "buffer index out of range\n");
-               return -EINVAL;
-       }
        vb = vb2_get_buffer(q, b->index);
        if (!vb) {
                dprintk(q, 1, "can't find the requested buffer %u\n", b->index);
@@ -892,10 +888,6 @@ int vb2_expbuf(struct vb2_queue *q, struct v4l2_exportbuffer *eb)
 {
        struct vb2_buffer *vb;
 
-       if (eb->index >= q->num_buffers) {
-               dprintk(q, 1, "buffer index out of range\n");
-               return -EINVAL;
-       }
        vb = vb2_get_buffer(q, eb->index);
        if (!vb) {
                dprintk(q, 1, "can't find the requested buffer %u\n", eb->index);