drm/i915: Apply WaUse32BppForSRWM to elk as well as ctg
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 14 May 2021 12:57:41 +0000 (15:57 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 22 Sep 2021 13:49:21 +0000 (16:49 +0300)
The w/a database lists this for both ctg and elk. So let's apply it to
elk as well. And add the w/a name.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210514125751.17075-5-ville.syrjala@linux.intel.com
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
drivers/gpu/drm/i915/intel_pm.c

index 456bc6e16fc98f6a9a43b3351de91037bfbf6211..74fd6aa7afc783b166f6e47a96bd95814a6a360b 100644 (file)
@@ -1152,17 +1152,13 @@ static u16 g4x_compute_wm(const struct intel_crtc_state *crtc_state,
        cpp = plane_state->hw.fb->format->cpp[0];
 
        /*
-        * Not 100% sure which way ELK should go here as the
-        * spec only says CL/CTG should assume 32bpp and BW
-        * doesn't need to. But as these things followed the
-        * mobile vs. desktop lines on gen3 as well, let's
-        * assume ELK doesn't need this.
+        * WaUse32BppForSRWM:ctg,elk
         *
-        * The spec also fails to list such a restriction for
-        * the HPLL watermark, which seems a little strange.
+        * The spec fails to list this restriction for the
+        * HPLL watermark, which seems a little strange.
         * Let's use 32bpp for the HPLL watermark as well.
         */
-       if (IS_GM45(dev_priv) && plane->id == PLANE_PRIMARY &&
+       if (plane->id == PLANE_PRIMARY &&
            level != G4X_WM_LEVEL_NORMAL)
                cpp = max(cpp, 4u);