drm/rockchip: lvds: do not print scary message when probing defer
authorQuentin Schulz <quentin.schulz@theobroma-systems.com>
Mon, 20 Nov 2023 12:29:49 +0000 (13:29 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 4 Jan 2024 10:45:55 +0000 (11:45 +0100)
This scary message can misled the user into thinking something bad has
happened and needs to be fixed, however it could simply be part of a
normal boot process where EPROBE_DEFER is taken into account. Therefore,
let's use dev_err_probe so that this message doesn't get shown (by
default) when the return code is EPROBE_DEFER.

Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS")
Cc: Quentin Schulz <foss+kernel@0leil.net>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231120-rk-lvds-defer-msg-v2-2-9c59a5779cf9@theobroma-systems.com
drivers/gpu/drm/rockchip/rockchip_lvds.c

index 6ecb6b8a1dcde013ebf0052994a54396df2a0a07..77b76cff1adb9dc8701b647dbfda45eaa0829558 100644 (file)
@@ -576,7 +576,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master,
                ret = -EINVAL;
                goto err_put_port;
        } else if (ret) {
-               DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n");
+               dev_err_probe(dev, ret, "failed to find panel and bridge node\n");
                goto err_put_port;
        }
        if (lvds->panel)