x86/smpboot: Remove a stray comment about CPU hotplug
authorSohil Mehta <sohil.mehta@intel.com>
Thu, 27 Jul 2023 18:05:31 +0000 (18:05 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 28 Jul 2023 08:17:53 +0000 (10:17 +0200)
This old comment is irrelavant to the logic of disabling interrupts and
could be misleading. Remove it.

Now, hlt_play_dead() resembles the code that the comment was initially
added for, but, it doesn't make sense anymore because an offlined cpu
could also be put into other states such as mwait.

Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230727180533.3119660-2-sohil.mehta@intel.com
arch/x86/kernel/smpboot.c

index e1aa2cd7734ba40825f83ecfe01e25fd41b8e5a4..6a09a021b5346bcee3b29843270872cf345dc0b4 100644 (file)
@@ -1614,9 +1614,7 @@ void play_dead_common(void)
        idle_task_exit();
 
        cpuhp_ap_report_dead();
-       /*
-        * With physical CPU hotplug, we should halt the cpu
-        */
+
        local_irq_disable();
 }