staging: rtl8723bs: core: Remove unnecessary parentheses
authorKushal Kothari <kushalkothari285@gmail.com>
Sat, 23 Oct 2021 07:35:48 +0000 (13:05 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 Oct 2021 12:31:07 +0000 (14:31 +0200)
Issue found with checkpatch.pl.
CHECK: Remove unnecessary parentheses

Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
Link: https://lore.kernel.org/r/f4df671b9bf23f9e8995dd03472a520d40377d7a.1634967010.git.kushalkothari285@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_cmd.c

index acd4e8b1fad5310baf6fbd7a2d2e6f68608541e3..88f6b7405106b1c2b8a5643ea726c8380fc14476 100644 (file)
@@ -278,10 +278,10 @@ struct    cmd_obj *_rtw_dequeue_cmd(struct __queue *queue)
 
        /* spin_lock_bh(&(queue->lock)); */
        spin_lock_irqsave(&queue->lock, irqL);
-       if (list_empty(&(queue->queue)))
+       if (list_empty(&queue->queue))
                obj = NULL;
        else {
-               obj = container_of(get_next(&(queue->queue)), struct cmd_obj, list);
+               obj = container_of(get_next(&queue->queue), struct cmd_obj, list);
                list_del_init(&obj->list);
        }
 
@@ -371,7 +371,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd)
 void rtw_stop_cmd_thread(struct adapter *adapter)
 {
        if (adapter->cmdThread &&
-               atomic_read(&(adapter->cmdpriv.cmdthd_running)) &&
+               atomic_read(&adapter->cmdpriv.cmdthd_running) &&
                adapter->cmdpriv.stop_req == 0) {
                adapter->cmdpriv.stop_req = 1;
                complete(&adapter->cmdpriv.cmd_queue_comp);
@@ -387,7 +387,7 @@ int rtw_cmd_thread(void *context)
        u8 (*cmd_hdl)(struct adapter *padapter, u8 *pbuf);
        void (*pcmd_callback)(struct adapter *dev, struct cmd_obj *pcmd);
        struct adapter *padapter = context;
-       struct cmd_priv *pcmdpriv = &(padapter->cmdpriv);
+       struct cmd_priv *pcmdpriv = &padapter->cmdpriv;
        struct drvextra_cmd_parm *extra_parm = NULL;
 
        thread_enter("RTW_CMD_THREAD");
@@ -395,7 +395,7 @@ int rtw_cmd_thread(void *context)
        pcmdbuf = pcmdpriv->cmd_buf;
 
        pcmdpriv->stop_req = 0;
-       atomic_set(&(pcmdpriv->cmdthd_running), true);
+       atomic_set(&pcmdpriv->cmdthd_running, true);
        complete(&pcmdpriv->terminate_cmdthread_comp);
 
        while (1) {
@@ -471,7 +471,7 @@ _next:
 
 post_process:
 
-               if (mutex_lock_interruptible(&(pcmd->padapter->cmdpriv.sctx_mutex)) == 0) {
+               if (mutex_lock_interruptible(&pcmd->padapter->cmdpriv.sctx_mutex) == 0) {
                        if (pcmd->sctx) {
                                netdev_dbg(padapter->pnetdev,
                                           FUNC_ADPT_FMT " pcmd->sctx\n",
@@ -482,7 +482,7 @@ post_process:
                                else
                                        rtw_sctx_done_err(&pcmd->sctx, RTW_SCTX_DONE_CMD_ERROR);
                        }
-                       mutex_unlock(&(pcmd->padapter->cmdpriv.sctx_mutex));
+                       mutex_unlock(&pcmd->padapter->cmdpriv.sctx_mutex);
                }
 
                /* call callback function for post-processed */
@@ -522,7 +522,7 @@ post_process:
        } while (1);
 
        complete(&pcmdpriv->terminate_cmdthread_comp);
-       atomic_set(&(pcmdpriv->cmdthd_running), false);
+       atomic_set(&pcmdpriv->cmdthd_running, false);
 
        thread_exit();
 }
@@ -724,7 +724,7 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
        struct ht_priv          *phtpriv = &pmlmepriv->htpriv;
        enum ndis_802_11_network_infrastructure ndis_network_mode = pnetwork->network.infrastructure_mode;
        struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
-       struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
+       struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
        u32 tmp_len;
        u8 *ptmp = NULL;
 
@@ -1243,7 +1243,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
        u8 bBusyTraffic = false, bTxBusyTraffic = false, bRxBusyTraffic = false;
        u8 bHigherBusyTraffic = false, bHigherBusyRxTraffic = false, bHigherBusyTxTraffic = false;
 
-       struct mlme_priv        *pmlmepriv = &(padapter->mlmepriv);
+       struct mlme_priv        *pmlmepriv = &padapter->mlmepriv;
 
        collect_traffic_statistics(padapter);
 
@@ -1315,7 +1315,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
                struct dvobj_priv *dvobj = adapter_to_dvobj(padapter);
                int n_assoc_iface = 0;
 
-               if (check_fwstate(&(dvobj->padapters->mlmepriv), WIFI_ASOC_STATE))
+               if (check_fwstate(&dvobj->padapters->mlmepriv, WIFI_ASOC_STATE))
                        n_assoc_iface++;
 
                if (!from_timer && n_assoc_iface == 0)
@@ -1340,7 +1340,7 @@ static void dynamic_chk_wk_hdl(struct adapter *padapter)
 {
        struct mlme_priv *pmlmepriv;
 
-       pmlmepriv = &(padapter->mlmepriv);
+       pmlmepriv = &padapter->mlmepriv;
 
        if (check_fwstate(pmlmepriv, WIFI_AP_STATE))
                expire_timeout_chk(padapter);
@@ -1374,11 +1374,11 @@ void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps_ctrl_type);
 void lps_ctrl_wk_hdl(struct adapter *padapter, u8 lps_ctrl_type)
 {
        struct pwrctrl_priv *pwrpriv = adapter_to_pwrctl(padapter);
-       struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+       struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
        u8 mstatus;
 
-       if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) ||
-               (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE))) {
+       if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) ||
+               check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {
                return;
        }
 
@@ -1959,7 +1959,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
        struct wlan_network *pwlan = NULL;
        struct  mlme_priv *pmlmepriv = &padapter->mlmepriv;
        struct wlan_bssid_ex *pnetwork = (struct wlan_bssid_ex *)pcmd->parmbuf;
-       struct wlan_network *tgt_network = &(pmlmepriv->cur_network);
+       struct wlan_network *tgt_network = &pmlmepriv->cur_network;
 
        if (!pcmd->parmbuf)
                goto exit;
@@ -1983,20 +1983,20 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
                rtw_indicate_connect(padapter);
        } else {
                pwlan = rtw_alloc_network(pmlmepriv);
-               spin_lock_bh(&(pmlmepriv->scanned_queue.lock));
+               spin_lock_bh(&pmlmepriv->scanned_queue.lock);
                if (!pwlan) {
                        pwlan = rtw_get_oldest_wlan_network(&pmlmepriv->scanned_queue);
                        if (!pwlan) {
-                               spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
+                               spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
                                goto createbss_cmd_fail;
                        }
                        pwlan->last_scanned = jiffies;
                } else {
-                       list_add_tail(&(pwlan->list), &pmlmepriv->scanned_queue.queue);
+                       list_add_tail(&pwlan->list, &pmlmepriv->scanned_queue.queue);
                }
 
                pnetwork->length = get_wlan_bssid_ex_sz(pnetwork);
-               memcpy(&(pwlan->network), pnetwork, pnetwork->length);
+               memcpy(&pwlan->network, pnetwork, pnetwork->length);
                /* pwlan->fixed = true; */
 
                /* list_add_tail(&(pwlan->list), &pmlmepriv->scanned_queue.queue); */
@@ -2009,7 +2009,7 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
 
                _clr_fwstate_(pmlmepriv, _FW_UNDER_LINKING);
 
-               spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));
+               spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
                /*  we will set _FW_LINKED when there is one more sat to join us (rtw_stassoc_event_callback) */
 
        }