projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b98186a
)
io_uring: fix tw losing poll events
author
Pavel Begunkov
<asml.silence@gmail.com>
Thu, 17 Nov 2022 18:40:15 +0000
(18:40 +0000)
committer
Jens Axboe
<axboe@kernel.dk>
Thu, 17 Nov 2022 19:33:33 +0000
(12:33 -0700)
We may never try to process a poll wake and its mask if there was
multiple wake ups racing for queueing up a tw. Force
io_poll_check_events() to update the mask by vfs_poll().
Cc: stable@vger.kernel.org
Fixes: aa43477b04025 ("io_uring: poll rework")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link:
https://lore.kernel.org/r/00344d60f8b18907171178d7cf598de71d127b0b.1668710222.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/poll.c
patch
|
blob
|
history
diff --git
a/io_uring/poll.c
b/io_uring/poll.c
index 90920abf91ff7d7c424bc09b034ebec73431b986..c34019b182113451c7bf64ce45766ba72c518116 100644
(file)
--- a/
io_uring/poll.c
+++ b/
io_uring/poll.c
@@
-228,6
+228,13
@@
static int io_poll_check_events(struct io_kiocb *req, bool *locked)
return IOU_POLL_DONE;
if (v & IO_POLL_CANCEL_FLAG)
return -ECANCELED;
+ /*
+ * cqe.res contains only events of the first wake up
+ * and all others are be lost. Redo vfs_poll() to get
+ * up to date state.
+ */
+ if ((v & IO_POLL_REF_MASK) != 1)
+ req->cqe.res = 0;
/* the mask was stashed in __io_poll_execute */
if (!req->cqe.res) {