bcachefs: better error message in btree_node_write_work()
authorKent Overstreet <kent.overstreet@linux.dev>
Sun, 24 Dec 2023 02:09:34 +0000 (21:09 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Mon, 1 Jan 2024 16:47:42 +0000 (11:47 -0500)
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_io.c
fs/bcachefs/errcode.h

index d99c237c88733204799ea76f291dfcf81a743931..d7cac6a805072279fe2d925a1190e3037a57fcac 100644 (file)
@@ -1798,8 +1798,10 @@ static void btree_node_write_work(struct work_struct *work)
        bch2_bkey_drop_ptrs(bkey_i_to_s(&wbio->key), ptr,
                bch2_dev_list_has_dev(wbio->wbio.failed, ptr->dev));
 
-       if (!bch2_bkey_nr_ptrs(bkey_i_to_s_c(&wbio->key)))
+       if (!bch2_bkey_nr_ptrs(bkey_i_to_s_c(&wbio->key))) {
+               ret = -BCH_ERR_btree_write_all_failed;
                goto err;
+       }
 
        if (wbio->wbio.first_btree_write) {
                if (wbio->wbio.failed.nr) {
index 716ff643dc85216bd9af202766560f53fb1c6763..9d53b7fd6e84743862a796983343eface883b958 100644 (file)
        x(BCH_ERR_operation_blocked,    nocow_lock_blocked)                     \
        x(EIO,                          btree_node_read_err)                    \
        x(EIO,                          sb_not_downgraded)                      \
+       x(EIO,                          btree_write_all_failed)                 \
        x(BCH_ERR_btree_node_read_err,  btree_node_read_err_fixable)            \
        x(BCH_ERR_btree_node_read_err,  btree_node_read_err_want_retry)         \
        x(BCH_ERR_btree_node_read_err,  btree_node_read_err_must_retry)         \