usb: typec: Return size of buffer if pd_set operation succeeds
authorKyle Tso <kyletso@google.com>
Tue, 19 Mar 2024 07:43:09 +0000 (15:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Mar 2024 13:59:13 +0000 (14:59 +0100)
The attribute writing should return the number of bytes used from the
buffer on success.

Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240319074309.3306579-1-kyletso@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/class.c

index 389c7f0b8d9358431890bc843e8007b6e92e9d97..9610e647a8d48006e776019c1ddc9eb6a7fddd4a 100644 (file)
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 {
        struct typec_port *port = to_typec_port(dev);
        struct usb_power_delivery *pd;
+       int ret;
 
        if (!port->ops || !port->ops->pd_set)
                return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
        if (!pd)
                return -EINVAL;
 
-       return port->ops->pd_set(port, pd);
+       ret = port->ops->pd_set(port, pd);
+       if (ret)
+               return ret;
+
+       return size;
 }
 
 static ssize_t select_usb_power_delivery_show(struct device *dev,