crypto: ccp - Get a free page to use while fetching initial nonce
authorMario Limonciello <mario.limonciello@amd.com>
Tue, 29 Aug 2023 15:07:55 +0000 (10:07 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Sep 2023 10:29:45 +0000 (18:29 +0800)
dbc_dev_init() gets a free page from `GFP_KERNEL`, but if that page has
any data in it the first nonce request will fail.
This prevents dynamic boost control from probing. To fix this, explicitly
request a zeroed page with `__GFP_ZERO` to ensure first nonce fetch works.

Fixes: c04cf9e14f10 ("crypto: ccp - Add support for fetching a nonce for dynamic boost control")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccp/dbc.c

index 839ea14b9a853f1737ad7693b4c719dc024c3de0..6f33149ef80df0f25ea10990d9ad3b04242ca1cb 100644 (file)
@@ -205,7 +205,7 @@ int dbc_dev_init(struct psp_device *psp)
                return -ENOMEM;
 
        BUILD_BUG_ON(sizeof(union dbc_buffer) > PAGE_SIZE);
-       dbc_dev->mbox = (void *)devm_get_free_pages(dev, GFP_KERNEL, 0);
+       dbc_dev->mbox = (void *)devm_get_free_pages(dev, GFP_KERNEL | __GFP_ZERO, 0);
        if (!dbc_dev->mbox) {
                ret = -ENOMEM;
                goto cleanup_dev;