tools: tests: modify delays in toggle test
authorJoe Slater <joe.slater@windriver.com>
Tue, 6 Jun 2023 15:04:27 +0000 (08:04 -0700)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 6 Jun 2023 15:18:31 +0000 (17:18 +0200)
The test "gpioset: toggle (continuous)" uses fixed delays to test
toggling values. This is not reliable, so we switch to looking
for transitions from one value to another.

We wait for a transition up to 1.5 seconds.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
tools/gpio-tools-test.bats

index c83ca7de104b160b59cc864b62202dbaa7faec7a..929c35a6f6e8eefa542e5123788fbfc6c89f4906 100755 (executable)
@@ -141,6 +141,20 @@ gpiosim_check_value() {
        [ "$VAL" = "$EXPECTED" ]
 }
 
+gpiosim_wait_value() {
+       local OFFSET=$2
+       local EXPECTED=$3
+       local DEVNAME=${GPIOSIM_DEV_NAME[$1]}
+       local CHIPNAME=${GPIOSIM_CHIP_NAME[$1]}
+       local PORT=$GPIOSIM_SYSFS/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/value
+
+       for i in {1..15}; do
+               [ "$(<$PORT)" = "$EXPECTED" ] && return
+               sleep 0.1
+       done
+       return 1
+}
+
 gpiosim_cleanup() {
        for CHIP in ${!GPIOSIM_CHIP_NAME[@]}
        do
@@ -1567,15 +1581,12 @@ request_release_line() {
        gpiosim_check_value sim0 4 0
        gpiosim_check_value sim0 7 0
 
-       sleep 1
-
-       gpiosim_check_value sim0 1 0
+       gpiosim_wait_value sim0 1 0
        gpiosim_check_value sim0 4 1
        gpiosim_check_value sim0 7 1
 
-       sleep 1
 
-       gpiosim_check_value sim0 1 1
+       gpiosim_wait_value sim0 1 1
        gpiosim_check_value sim0 4 0
        gpiosim_check_value sim0 7 0
 }