xfs: fix uninitialized variable in xfs_attr3_leaf_inactive
authorDarrick J. Wong <darrick.wong@oracle.com>
Thu, 23 Jan 2020 15:54:09 +0000 (07:54 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 24 Jan 2020 00:11:32 +0000 (16:11 -0800)
Dan Carpenter pointed out that error is uninitialized.  While there
never should be an attr leaf block with zero entries, let's not leave
that logic bomb there.

Fixes: 0bb9d159bd01 ("xfs: streamline xfs_attr3_leaf_inactive")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
fs/xfs/xfs_attr_inactive.c

index c75840a9e47802304e8aef32408a23881c4022e3..8fbb841cd6fee2b550ff9209e2ca8f481d694d3c 100644 (file)
@@ -89,7 +89,7 @@ xfs_attr3_leaf_inactive(
        struct xfs_attr_leafblock       *leaf = bp->b_addr;
        struct xfs_attr_leaf_entry      *entry;
        struct xfs_attr_leaf_name_remote *name_rmt;
-       int                             error;
+       int                             error = 0;
        int                             i;
 
        xfs_attr3_leaf_hdr_from_disk(mp->m_attr_geo, &ichdr, leaf);