w1: gpio: Remove duplicate NULL checks
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 7 Mar 2024 14:35:50 +0000 (16:35 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 25 Mar 2024 11:06:37 +0000 (12:06 +0100)
gpiod_set_value() is NULL-aware, no need to check that in the caller.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20240307143644.3787260-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/w1/masters/w1-gpio.c

index 3881f2eaed2f5ae8932a75a7806ba3443f59fcbb..8fd9fedd8c567d91d51b3db2a9042cbf1302b63e 100644 (file)
@@ -117,8 +117,7 @@ static int w1_gpio_probe(struct platform_device *pdev)
        if (err)
                return dev_err_probe(dev, err, "w1_add_master device failed\n");
 
-       if (ddata->pullup_gpiod)
-               gpiod_set_value(ddata->pullup_gpiod, 1);
+       gpiod_set_value(ddata->pullup_gpiod, 1);
 
        platform_set_drvdata(pdev, master);
 
@@ -130,8 +129,7 @@ static void w1_gpio_remove(struct platform_device *pdev)
        struct w1_bus_master *master = platform_get_drvdata(pdev);
        struct w1_gpio_ddata *ddata = master->data;
 
-       if (ddata->pullup_gpiod)
-               gpiod_set_value(ddata->pullup_gpiod, 0);
+       gpiod_set_value(ddata->pullup_gpiod, 0);
 
        w1_remove_master_device(master);
 }