drm/amd/display: Always exit DMCUB idle when called
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Mon, 11 Dec 2023 22:54:57 +0000 (17:54 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 3 Jan 2024 15:46:36 +0000 (10:46 -0500)
[Why]
dc->idle_optimizations_allowed may be desynced with the hardware state.

[How]
Make sure we always exit out when dc_dmub_srv_exit_low_power_state is
called by removing the check.

Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: Sung joon Kim <sungjoon.kim@amd.com>
Acked-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c

index 1d315f7cdce381ef09ca7e632bf3a7ef20b4ee70..4ce8ac966cc8138bf295686b49c4e67c626defa2 100644 (file)
@@ -1222,9 +1222,6 @@ static void dc_dmub_srv_exit_low_power_state(const struct dc *dc)
        if (dc->debug.dmcub_emulation)
                return;
 
-       if (!dc->idle_optimizations_allowed)
-               return;
-
        if (!dc->ctx->dmub_srv || !dc->ctx->dmub_srv->dmub)
                return;