gpiosim: add an enum representing line active state

In order to avoid confusion and stress the fact that "value" represents
the logical state of a GPIO line, add a two-value enum with the names
"ACTIVE" and "INACTIVE" to the libgpiosim API.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

diff --git a/tests/gpiosim/gpiosim-selftest.c b/tests/gpiosim/gpiosim-selftest.c
index 205580d96a7420b5969f873d0a4c7ceae3888887..f2d0b35b34af3d88394d68f53ba22355e83dd4ef 100644 (file)
--- a/tests/gpiosim/gpiosim-selftest.c
+++ b/tests/gpiosim/gpiosim-selftest.c
@@ -135,7 +135,7 @@ int main(int argc UNUSED, char **argv UNUSED)
                return EXIT_FAILURE;
        }
 
-       if (ret != 1) {
+       if (ret != GPIOSIM_VALUE_ACTIVE) {
                fprintf(stderr, "Invalid value read\n");
                return EXIT_FAILURE;
        }

diff --git a/tests/gpiosim/gpiosim.c b/tests/gpiosim/gpiosim.c
index ea5357a0005fb023daca1bb1a875a190db023ef5..3e13ff9f03552b85707e76008b73b93606e6b1b2 100644 (file)
--- a/tests/gpiosim/gpiosim.c
+++ b/tests/gpiosim/gpiosim.c
@@ -982,9 +982,9 @@ GPIOSIM_API int gpiosim_bank_get_value(struct gpiosim_bank *bank,
                return ret;
 
        if (what[0] == '0')
-               return 0;
+               return GPIOSIM_VALUE_INACTIVE;
        if (what[0] == '1')
-               return 1;
+               return GPIOSIM_VALUE_ACTIVE;
 
        errno = EIO;
        return -1;

diff --git a/tests/gpiosim/gpiosim.h b/tests/gpiosim/gpiosim.h
index 25b245af28f62282e6a94caa9d64bc363045df9e..32f81bc62d123b36556cf5a6549c1676d8560862 100644 (file)
--- a/tests/gpiosim/gpiosim.h
+++ b/tests/gpiosim/gpiosim.h
@@ -15,6 +15,11 @@ struct gpiosim_ctx;
 struct gpiosim_dev;
 struct gpiosim_bank;
 
+enum {
+       GPIOSIM_VALUE_INACTIVE = 0,
+       GPIOSIM_VALUE_ACTIVE = 1,
+};
+
 enum {
        GPIOSIM_PULL_DOWN = 1,
        GPIOSIM_PULL_UP,